Skip to content

fix(privacy): omit provider IDs from routine batch logs - #317

Draft
seonghobae wants to merge 8 commits into
fix/recovery-evidence-weakref-coverage-b84f0c9from
fix/low-cardinality-batch-id-logs-b84f0c9
Draft

fix(privacy): omit provider IDs from routine batch logs#317
seonghobae wants to merge 8 commits into
fix/recovery-evidence-weakref-coverage-b84f0c9from
fix/low-cardinality-batch-id-logs-b84f0c9

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Addresses #301 through the existing low-cardinality batch-log privacy lane. This remains a Draft child of dependency-root #233; protected main is not written directly.

Fresh exact stack

  • live protected main: bdff1273d3885dedc5187632e1c8838b470c9b6d;
  • exact predecessor/base test(recovery): cover stale evidence registry cleanup #233: 32469711f9a26a26ebcf4a7efcf20938bfdc94db;
  • exact current head: a4271f1654ba3fd3c07b34a4ad4624a96794db64;
  • state: Draft, open, mechanically mergeable.

The previous body described predecessor head 4289f006...; all checks/reviews on that or earlier heads are historical after branch movement.

Bounded behavior

The lane removes provider file/batch identifiers from ordinary INFO success logs while preserving authorized API return values, lifecycle/retry/retention behavior, persistence, and provider request semantics. It does not broaden masking into a product-breaking blanket redaction policy.

The privacy source/test delta remains owned here; #233 separately owns the inherited recovery-evidence coverage arcs. Central CodeQL/runner and Strix evidence defects remain read-only .github owner concerns and are not converted into pg source findings.

Exact-current validation boundary

Fresh workflow inventory for exact a4271f1654ba3fd3c07b34a4ad4624a96794db64 is non-passing: CI 33722286086 and Release Acceptance 33722286053 are queued. No predecessor success, COMMENTED/model disposition, or central infrastructure state transfers to this head.

Integration boundary

Keep Draft until #233 integrates and the unchanged/reconciled final head obtains every then-live exact-current CI/security/SAST/coverage/docstrings/package/SBOM/provenance/release/review/thread gate. Reconcile non-destructively onto protected main after the predecessor lands.

No force push, destructive rebase, self-approval, gate weakening, source churn merely to retrigger infrastructure, or close-to-zero PR handling.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Fresh exact-head blocker RCA for #317@273a785642adcc5cb7ab72272a113e1ba6de8eae against protected main@b84f0c94154043a3473939c01bb6471de5a129ae:

  • Required Strix Security is terminal failure at run 33350356643, job 99363187573.
  • The trusted required workflow ran from central .github source SHA 046bc2beb2e0bb4be804255764bcbb4c49e973e9, materialized the exact PR head, and reached contextual-orchestrator provider routing.
  • Gateway preflight found one ready route, nvidia_nim_meta_llama_3_2_90b_vision_instruct (meta/llama-3.2-90b-vision-instruct), but the actual Strix request failed before the first model response with provider HTTP 400 / invalid_request_error, retryable: false. Three bounded attempts failed the same way; each produced 0 tokens and no authoritative vulnerability analysis. The wrapper correctly failed closed as STRIX_PROVIDER_UNAVAILABLE.
  • Therefore this failure is not evidence of a pg source/privacy defect and not evidence of zero vulnerabilities. Do not mutate this source lane to chase the provider failure; keep the PR Draft and require a fresh exact-head terminal Strix success after a material central/provider change.
  • The aggregate coverage gate is separately non-passing because protected main still carries the two weakref branch arcs covered by dependency-root test(recovery): cover stale evidence registry cleanup #233. Do not duplicate test(recovery): cover stale evidence registry cleanup #233's active test writer here.

Writer-collision correction: a fresh non-default-branch comparison shows no-PR branch agent/retry-after-parser-hardening@417e84bee6356d560201d36a760425c3d893646d is 4 commits ahead / 187 behind protected main and also modifies pg_llm_batch/batch_api_client.py. That is active-writer evidence on the same production file even though the branch is stale/diverged. Freeze further source mutation on #317 for this invocation; reconcile ownership/non-overlap before any future change to this file. The current #317 diff itself remains exactly two commits ahead / zero behind main and changes only pg_llm_batch/batch_api_client.py plus its focused privacy test.

@seonghobae seonghobae added area: api API, protocol, event, or external contract area: ci-cd CI, GitHub Actions, checks, release, or supply chain area: security Security boundary, hardening, or vulnerability prevention priority: medium Normal-priority or P2 work status: blocked Blocked by conflict, dependency, or required prerequisite type: bug Defect or incorrect behavior labels Aug 31, 2026 — with ChatGPT Codex Connector
@seonghobae
seonghobae changed the base branch from main to fix/recovery-evidence-weakref-coverage-b84f0c9 September 2, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: api API, protocol, event, or external contract area: ci-cd CI, GitHub Actions, checks, release, or supply chain area: security Security boundary, hardening, or vulnerability prevention priority: medium Normal-priority or P2 work status: blocked Blocked by conflict, dependency, or required prerequisite type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant